stevenzwu commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1397716578
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##########
@@ -429,6 +444,30 @@ public Builder<T> setAll(Map<String, String> properties) {
return this;
}
+ /**
+ * Emits watermarks once per split based on the file statistics for the
given split. The
+ * generated watermarks are also used for ordering the splits for read.
Accepted column types
+ * are timestamp/timestamptz/long. For long columns consider setting {@link
+ * #watermarkTimeUnit(TimeUnit)}.
+ */
+ public Builder<T> watermarkColumn(String columnName) {
+ Preconditions.checkArgument(
+ splitAssignerFactory == null,
+ "Watermark column and SplitAssigner should not be set in the same
source");
+ this.watermarkColumn = columnName;
+ return this;
+ }
+
+ /**
+ * When the type of the {@link #watermarkColumn} is {@link
+ * org.apache.iceberg.types.Types.LongType}, then sets the {@link
TimeUnit} to convert the
+ * value. The default value is {@link TimeUnit#MICROSECONDS}.
+ */
+ public Builder<T> watermarkTimeUnit(TimeUnit timeUnit) {
Review Comment:
ok. sounds reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
