my-vegetable-has-exploded commented on issue #98: URL: https://github.com/apache/iceberg-rust/issues/98#issuecomment-1817747650
Sorry, I am confusing about this issue. According to [iceberg#4360](https://github.com/apache/iceberg/pull/4360), I think UnboundPartitionSpec provides a build method without a schema and can be later bound to a schema. It seems that the primary action in the [bind function](https://github.com/apache/iceberg/blob/e69418ae8d6d041acae0af4fe59ea3c8b8f8705f/api/src/main/java/org/apache/iceberg/UnboundPartitionSpec.java#L53) involves retrieving the source type from the schema and initializing the transform with the source type. But in iceberg-rust, our transformFunction don't need source type to build. We determine source type using ```arrow_array.data_type()``` likes [TransformFunction for Bucket](https://github.com/apache/iceberg-rust/blob/3b5c35ebc0b6e47bfaf74167711e7b605d994ab3/crates/iceberg/src/transform/bucket.rs#L89). Do you think we still need this feature? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
