aokolnychyi commented on code in PR #9029:
URL: https://github.com/apache/iceberg/pull/9029#discussion_r1401282710
##########
core/src/main/java/org/apache/iceberg/SerializableTable.java:
##########
@@ -237,7 +236,14 @@ public EncryptionManager encryption() {
@Override
public LocationProvider locationProvider() {
- return locationProvider;
+ if (lazyLocationProvider == null) {
+ synchronized (this) {
+ if (lazyLocationProvider == null) {
+ lazyLocationProvider = LocationProviders.locationsFor(location,
properties);
Review Comment:
Minor: `lazyLocationProvider = ...` -> `this.lazyLocationProvider = ...` to
match the existing style of the class. We usually use `this.` prefix when
assigning a value to an instance variable to highlight that it is an instance
variable. We don't use `this.` whenever accessing such variables so no need to
change that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
