ajantha-bhat commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1401732524


##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java:
##########
@@ -132,74 +130,42 @@ protected void doRefresh() {
 
   @Override
   protected void doCommit(TableMetadata base, TableMetadata metadata) {
+    try {
+      Content content =
+          
client.getApi().getContent().key(key).reference(client.getReference()).get().get(key);
+      if (content != null) {

Review Comment:
   `createTableViaTransactionThatAlreadyExistsAsView` from `ViewCatalogTests` 
will fail without this check. It throws `NessieBadRequestException` without 
this check. 
   
   doRefresh() won't be called when Iceberg calls `commitTransaction` from 
above testcase. Hence, it needs this check. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to