gyfora commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1401758704
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##########
@@ -453,6 +492,18 @@ public IcebergSource<T> build() {
contextBuilder.project(FlinkSchemaUtil.convert(icebergSchema,
projectedFlinkSchema));
}
+ SerializableRecordEmitter<T> emitter =
SerializableRecordEmitter.defaultEmitter();
+ if (watermarkColumn != null) {
Review Comment:
@stevenzwu @pvary , given that the combining logic was already present
before this PR and is independent, I suggest we keep the current default
behaviour. (Like it's currently done in the PR)
@stevenzwu if you feel that the default combining logic should change for
the Flink source, please open a separate discussion, but I personally feel that
the current default is reasonable. This way Flink aligns with the default
iceberg planner behaviour, but this should not be discussed further here I
think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
