nastra commented on code in PR #9048:
URL: https://github.com/apache/iceberg/pull/9048#discussion_r1401886198
##########
build.gradle:
##########
@@ -948,6 +948,48 @@ project(':iceberg-snowflake') {
}
}
+project(':iceberg-tencentcloud') {
+ test {
+ useJUnitPlatform()
+ }
+
+ dependencies {
+ implementation project(path: ':iceberg-bundled-guava', configuration:
'shadow')
+ api project(':iceberg-api')
+ implementation project(':iceberg-core')
+ implementation project(':iceberg-common')
+
+ compileOnly (libs.cos.sdk) {
+ exclude group: 'com.google.code.gson', module: 'gson'
+ }
+ compileOnly (libs.cos.sdk.bundle) {
+ exclude group: 'com.google.code.gson', module: 'gson'
+ }
+ compileOnly libs.jaxb.api
+ compileOnly libs.activation
+ compileOnly libs.jaxb.runtime
+ compileOnly(libs.hadoop2.common) {
+ exclude group: 'org.apache.avro', module: 'avro'
+ exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ exclude group: 'javax.servlet', module: 'servlet-api'
+ exclude group: 'com.google.code.gson', module: 'gson'
+ }
+
+ testImplementation libs.jackson.dataformat.xml
+ testImplementation project(path: ':iceberg-api', configuration:
'testArtifacts')
+ testImplementation libs.spring.web
Review Comment:
why are all these spring dependencies defined here? I haven't seen any usage
of those in the tests. I'd suggest to remove dependencies that aren't necessary
and slim this down to the absolute minimum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
