nk1506 commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1402866684
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -207,11 +195,15 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
updateHiveTable = true;
LOG.debug("Committing existing table: {}", fullName);
} else {
- tbl = newHmsTable(metadata);
+ tbl =
+ newHmsTable(
+ metadata.property(HiveCatalog.HMS_TABLE_OWNER,
HiveHadoopUtil.currentUser()));
Review Comment:
For views, I thought it's always going to be
[CurrentUser](https://github.com/apache/iceberg/pull/8907/files#diff-db46657b84d66e084e15f31b8dab21577efb2ae7102863f94c6c9477782de676R320).
But I think it makes sense to get the tableOwner from ViewMetadata as well if
Present.
Still we will have to expect user information from Caller of `newHmsTable` ,
right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
