emkornfield commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1404501309
########## format/spec.md: ########## @@ -607,6 +611,8 @@ Notes: 1. An alternative, *strict projection*, creates a partition predicate that will match a file if all of the rows in the file must match the scan predicate. These projections are used to calculate the residual predicates for each file in a scan. 2. For example, if `file_a` has rows with `id` between 1 and 10 and a delete file contains rows with `id` between 1 and 4, a scan for `id = 9` may ignore the delete file because none of the deletes can match a row that will be selected. +3. Floating point partition values are considered equal if there IEEE 754 floating-point “single format” bit layout Review Comment: fixed typo. @rdblue this is a separate clarification from https://github.com/apache/iceberg/pull/8981 for equality deletes floating points are already prohibited (as they are for a primary key). For partitions it appears identity transforms are allowed to apply to floating point numbers, this tries to clarify how comparisons should be done in this scenario (I assume we can't exclude floating point numbers from identity transforms at this point?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
