pvary commented on code in PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#discussion_r1409261131
##########
.palantir/revapi.yml:
##########
@@ -877,6 +877,27 @@ acceptedBreaks:
- code: "java.field.serialVersionUIDChanged"
new: "field org.apache.iceberg.util.SerializableMap<K,
V>.serialVersionUID"
justification: "Serialization is not be used"
+ - code: "java.method.nowStatic"
+ old: "method
org.apache.iceberg.BaseMetastoreTableOperations.CommitStatus
org.apache.iceberg.BaseMetastoreTableOperations::checkCommitStatus(java.lang.String,\
+ \ org.apache.iceberg.TableMetadata)"
+ new: "method
org.apache.iceberg.BaseMetastoreTableOperations.CommitStatus
org.apache.iceberg.BaseMetastoreTableOperations::checkCommitStatus(java.lang.String,\
+ \ java.lang.String, java.util.Map<java.lang.String, java.lang.String>,
java.util.function.Function<java.lang.String,\
+ \ java.lang.Boolean>)"
+ justification: "Increased visibility and refactor methods for view
operation"
+ - code: "java.method.numberOfParametersChanged"
+ old: "method
org.apache.iceberg.BaseMetastoreTableOperations.CommitStatus
org.apache.iceberg.BaseMetastoreTableOperations::checkCommitStatus(java.lang.String,\
+ \ org.apache.iceberg.TableMetadata)"
+ new: "method
org.apache.iceberg.BaseMetastoreTableOperations.CommitStatus
org.apache.iceberg.BaseMetastoreTableOperations::checkCommitStatus(java.lang.String,\
+ \ java.lang.String, java.util.Map<java.lang.String, java.lang.String>,
java.util.function.Function<java.lang.String,\
+ \ java.lang.Boolean>)"
+ justification: "Increased visibility and refactor methods for view
operation"
+ - code: "java.method.visibilityIncreased"
Review Comment:
This is probably acceptable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
