bitsondatadev commented on code in PR #178:
URL: https://github.com/apache/iceberg-python/pull/178#discussion_r1415369470
##########
tests/catalog/test_sql.py:
##########
@@ -21,6 +21,7 @@
import pytest
from pytest import TempPathFactory
+from pytest_lazyfixture import lazy_fixture
Review Comment:
Clever :)
##########
mkdocs/docs/configuration.md:
##########
@@ -150,6 +151,22 @@ catalog:
uri: postgresql+psycopg2://username:password@localhost/mydatabase
```
+In the case of SQLite:
+
+<!-- prettier-ignore-start -->
+
+!!! warning inline end "Development only"
+ SQLite is not built for concurrency, and should only be used for
exploratory or development purposes.
Review Comment:
Avoid passive.
```suggestion
SQLite is not built for concurrency, you should use this catalog for
exploratory or development purposes.
```
##########
mkdocs/docs/configuration.md:
##########
@@ -140,8 +140,9 @@ catalog:
## SQL Catalog
-The SQL catalog requires a database for its backend. As of now, pyiceberg only
supports PostgreSQL through psycopg2.
-The database connection has to be configured using the `uri` property (see
SQLAlchemy's [documentation for URL
format](https://docs.sqlalchemy.org/en/20/core/engines.html#backend-specific-urls)):
+The SQL catalog requires a database for its backend. PyIceberg supports
PostgreSQL and SQLite through psycopg2. The database connection has to be
configured using the `uri` property (see SQLAlchemy's [documentation for URL
format](https://docs.sqlalchemy.org/en/20/core/engines.html#backend-specific-urls)):
Review Comment:
```suggestion
The SQL catalog requires a database for its backend. PyIceberg supports
PostgreSQL and SQLite through psycopg2. The database connection has to be
configured using the `uri` property. See SQLAlchemy's [documentation for URL
format](https://docs.sqlalchemy.org/en/20/core/engines.html#backend-specific-urls):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
