mas-chen commented on code in PR #9173:
URL: https://github.com/apache/iceberg/pull/9173#discussion_r1416071311
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##########
@@ -105,12 +107,12 @@ public class IcebergSource<T> implements Source<T,
IcebergSourceSplit, IcebergEn
this.readerFunction = readerFunction;
this.assignerFactory = assignerFactory;
this.splitComparator = splitComparator;
- this.table = table;
this.emitter = emitter;
+ this.tableName = table.name();
Review Comment:
https://github.com/apache/iceberg/blob/8b7a280a9fd0b51eb43538fbb9f6879d1c92de18/flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java#L482
The builder method already handles the nullity case. I added a preconditions
to verify that table is non-null before invoking the source constructor.
We can move `checkRequired` into the constructor too (I think that makes the
code more readable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
