liurenjie1024 commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1420028918
##########
crates/iceberg/src/spec/transform.rs:
##########
@@ -126,17 +126,20 @@ pub enum Transform {
impl Transform {
/// Get the return type of transform given the input type.
/// Returns `None` if it can't be transformed.
- pub fn result_type(&self, input_type: &Type) -> Option<Type> {
+ pub fn result_type(&self, input_type: &Type) -> Result<Type> {
Review Comment:
They have different meaning. When return `Option`, it acts more like a check
to say if this transform can be applied, and whether it's an error is up to
user. But their difference seems negligible. cc @Xuanwo @JanKaul @Fokko What do
you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
