rodmeneses commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1420797428
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java:
##########
@@ -193,109 +192,106 @@ private static void assertEquals(
return;
}
- Assert.assertTrue(
- "expected and actual should be both null or not null", expected !=
null && actual != null);
+ assertThat(expected).isNotNull();
+ assertThat(actual).isNotNull();
Review Comment:
from the previous assertion I can read:
```"expected and actual should be both null or not null```
however, this block
```java
assertThat(expected).isNotNull();
assertThat(actual).isNotNull();
```
is only asserting that both of them are not null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
