edgarRd commented on a change in pull request #1094:
URL: https://github.com/apache/iceberg/pull/1094#discussion_r435543965
##########
File path: core/src/main/java/org/apache/iceberg/AllEntriesTable.java
##########
@@ -82,18 +83,21 @@ public Schema schema() {
private Scan(
TableOperations ops, Table table, Long snapshotId, Schema schema,
Expression rowFilter,
- boolean caseSensitive, boolean colStats, Collection<String>
selectedColumns,
- ImmutableMap<String, String> options) {
- super(ops, table, snapshotId, schema, rowFilter, caseSensitive,
colStats, selectedColumns, options);
+ boolean ignoreResiduals, boolean caseSensitive, boolean colStats,
+ Collection<String> selectedColumns, ImmutableMap<String, String>
options) {
+ super(
Review comment:
The list of parameters seems really large, it produces a bunch of
changes for adding a new param and it's hard to track. Would it make sense to
refactor into an object like `TableScanOptions` or `TableScanContext` and
create appropriate builders?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
