ZENOTME commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1424780979
##########
crates/iceberg/src/spec/manifest_list.rs:
##########
@@ -30,6 +30,9 @@ use self::{
use super::{FormatVersion, StructType};
+/// The seq number when no added files are present.
+pub const UNASSIGNED_SEQ_NUMBER: i64 = -1;
Review Comment:
I guess for v2, here the min sequence number should be set as sequence
number.
https://github.com/apache/iceberg-python/blob/8c8abb5c4c258e32941110a9ce0938e1328290b3/pyiceberg/manifest.py#L934C1-L934C1
> The minimum data sequence number of all live data or delete files in the
manifest; use 0 when reading v1 manifest lists
I find that the minimum data sequence will be set if it the manifest has
live files(the file exist before), otherwise it will be set as sequence number
in manifest list writer.
https://github.com/apache/iceberg-python/blob/8c8abb5c4c258e32941110a9ce0938e1328290b3/pyiceberg/manifest.py#L733C1-L733C1
And I realize that I should not put the sequence number in manifest writer.
The sequence number only need set in manifest list. For manifest entry, [the
sequence number should be in read
process](https://iceberg.apache.org/spec/#sequence-number-inheritance).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
