ZENOTME commented on code in PR #79:
URL: https://github.com/apache/iceberg-rust/pull/79#discussion_r1424936927
##########
crates/iceberg/src/spec/partition.rs:
##########
@@ -69,6 +71,30 @@ impl PartitionSpec {
.iter()
.all(|f| matches!(f.transform, Transform::Void))
}
+
+ /// Returns the partition type of this partition spec.
+ pub fn partition_type(&self, schema: &Schema) -> Result<StructType, Error>
{
Review Comment:
> What should be the return type if no partition field?
For now, it return a empty struct type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
