stevenzwu commented on code in PR #9309:
URL: https://github.com/apache/iceberg/pull/9309#discussion_r1429218088
##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java:
##########
@@ -95,8 +97,7 @@ public class TestIcebergSourceWithWatermarkExtractor
implements Serializable {
.setRpcServiceSharing(RpcServiceSharing.DEDICATED)
.setConfiguration(
reporter.addToConfiguration(
- // disable classloader check as Avro may cache class in
the serializers.
- new
Configuration().set(CoreOptions.CHECK_LEAKED_CLASSLOADER, false)))
+ new
Configuration().set(PipelineOptions.ALLOW_UNALIGNED_SOURCE_SPLITS, true)))
Review Comment:
we probably need both options here
##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java:
##########
@@ -304,6 +322,11 @@ public void testThrottling() throws Exception {
try (CloseableIterator<RowData> resultIterator = stream.collectAsync()) {
JobClient jobClient = env.executeAsync("Iceberg Source Throttling Test");
+ CommonTestUtils.waitForAllTaskRunning(
Review Comment:
is this the main fix to make sure all tasks running first?
other code refactoring/reordering is just cosmetic/style thing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
