rdblue commented on PR #9230:
URL: https://github.com/apache/iceberg/pull/9230#issuecomment-1861657377

   Thanks, @jasonf20! The current version looks great. I'll commit it when 
tests are passing.
   
   For the issues caused by calling `commit` more than once, I think we should 
keep state and fail if someone calls `commit` a second time on an operation. 
Transaction creates operations, so we can have it work around that restriction 
by passing a flag when creating instances. Then we would close off the ability 
to do weird things by recommitting.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to