agrawalreetika commented on code in PR #9283:
URL: https://github.com/apache/iceberg/pull/9283#discussion_r1431230670


##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java:
##########
@@ -110,13 +110,18 @@ public void initialize(String name, Map<String, String> 
properties) {
 
     this.catalogName = name;
     this.warehouseLocation = 
LocationUtil.stripTrailingSlash(inputWarehouseLocation);
+
+    if (conf == null) {

Review Comment:
   @nastra If Hadoop Configuration is not set then subsequent would have 
NullPointer Excpetion. While adding the Tests I noticed we don't have conf 
check in `HadoopCatalog` the way we have it in `HiveCatalog`
   
   I can explicitly initialize conf in my Tests if you think this check is not 
required here. Let me know.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to