chinmay-bhat commented on code in PR #9342:
URL: https://github.com/apache/iceberg/pull/9342#discussion_r1432954411
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestReadProjection.java:
##########
@@ -64,11 +66,14 @@ public void testFullProjection() throws Exception {
Record projected = writeAndRead("full_projection", schema, schema, record);
- Assert.assertEquals(
- "Should contain the correct id value", 34L, (long)
projected.getField("id"));
+ assertThat((long) projected.getField("id"))
+ .as("Should contain the correct id value")
+ .isEqualTo(34L);
int cmp =
Comparators.charSequences().compare("test", (CharSequence)
projected.getField("data"));
+
+ // TODO: update this Assert with AssertJ
Review Comment:
> because you're changing this file it seems you'd also have to update
`TestSparkReadProjection`, otherwise CI won't pass.
>
> Alternatively you could reintroduce
>
> ```
> import org.junit.Assert;
> import org.junit.Rule;
> import org.junit.Test;
> import org.junit.rules.TemporaryFolder;
> ```
>
> but leave the AssertJ conversions in this file
Based on this comment, I thought we need to keep all those imports for
clearing CI, including the Assert import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
