nastra commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1434962899
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkInputFormat.java:
##########
@@ -140,9 +140,9 @@ public void testBasicProjection() throws IOException {
TestHelpers.assertRows(result, expected);
}
- @Test
+ @TestTemplate
public void testReadPartitionColumn() throws Exception {
- Assume.assumeTrue("Temporary skip ORC", FileFormat.ORC != fileFormat);
+ Assumptions.assumeTrue(FileFormat.ORC != fileFormat, "Temporary skip ORC");
Review Comment:
please use Assumptions from AssertJ: `assumeThat(fileFormat).as("Temporary
skip ORC").isNotEqualTo(FileFormat.ORC)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
