rdblue commented on code in PR #9366:
URL: https://github.com/apache/iceberg/pull/9366#discussion_r1435370739
##########
core/src/test/java/org/apache/iceberg/avro/TestAvroNameMapping.java:
##########
@@ -80,10 +80,7 @@ public void testMapProjections() throws IOException {
Record projected = writeAndRead(writeSchema, readSchema, record,
nameMapping);
// field id 5 comes from read schema
- Assertions.assertThat(projected.getSchema().getField("location_r5"))
- .as("Field missing from table mapping is renamed")
- .isNotNull();
- Assertions.assertThat(projected.get("location_r5"))
+ Assertions.assertThat(projected.get("location"))
Review Comment:
These test updates fix the odd behavior caused by rewriting the read schema.
Name mapping previously needed to produce fields with incorrect names in order
to project fields but not have them read (by name) from the data file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
