rdblue commented on code in PR #6004:
URL: https://github.com/apache/iceberg/pull/6004#discussion_r1435386937
##########
core/src/main/java/org/apache/iceberg/avro/ValueReaders.java:
##########
@@ -566,8 +569,10 @@ public Map<K, V> read(Decoder decoder, Object reuse)
throws IOException {
public abstract static class StructReader<S> implements ValueReader<S>,
SupportsRowPosition {
private final ValueReader<?>[] readers;
- private final int[] positions;
- private final Object[] constants;
+ private final int[] constantPositions;
+ private final Object[] constantValues;
+ private final int[] defaultPositions;
+ private final Object[] defaultValues;
Review Comment:
If we go with the approach in #9366, then we should no longer need changes
here, which was what originally made this difficult.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
