nastra commented on code in PR #9368:
URL: https://github.com/apache/iceberg/pull/9368#discussion_r1435550886
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/CatalogTestBase.java:
##########
@@ -30,7 +29,7 @@ public abstract class CatalogTestBase extends
TestBaseWithCatalog {
// these parameters are broken out to avoid changes that need to modify lots
of test suites
@Parameters(name = "catalogName = {0}, implementation = {1}, config = {2}")
- public static Object[][] parameters() {
+ protected static Object[][] parameters() {
Review Comment:
JUnit4 required this to be public but for JUnit5 we can make it protected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
