liurenjie1024 commented on code in PR #129: URL: https://github.com/apache/iceberg-rust/pull/129#discussion_r1435998742
########## crates/iceberg/src/spec/schema.rs: ########## @@ -32,16 +32,18 @@ use std::sync::Arc; use _serde::SchemaEnum; +/// Type alias for schema id. +pub type SchemaId = i32; Review Comment: I add this because I found that in different places we used different type, e.g. `i32`, `i64`. I think it improved readability, while without introducing any extra cost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
