rdblue commented on code in PR #9384:
URL: https://github.com/apache/iceberg/pull/9384#discussion_r1439060980
##########
core/src/main/java/org/apache/iceberg/deletes/SortingPositionOnlyDeleteWriter.java:
##########
@@ -60,7 +72,7 @@ public void write(PositionDelete<T> positionDelete) {
@Override
public long length() {
- return writer.length();
+ return result != null ? result.totalFileSizeInBytes() : 0L;
Review Comment:
Can you note this behavior in the Javadoc? I think it is correct to only
produce the size once it has been closed an produces a result, since that would
avoid any problem from wrapping this in a `RollingFileWriter`. But it is still
unexpected that this isn't accurate during the write.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
