aokolnychyi commented on code in PR #9384: URL: https://github.com/apache/iceberg/pull/9384#discussion_r1439592489
########## core/src/main/java/org/apache/iceberg/deletes/SortingPositionOnlyDeleteWriter.java: ########## @@ -60,7 +72,7 @@ public void write(PositionDelete<T> positionDelete) { @Override public long length() { - return writer.length(); + return result != null ? result.totalFileSizeInBytes() : 0L; Review Comment: I'll probably switch to not implementing it at all, just like we do in the other writer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org