szehon-ho commented on code in PR #8755: URL: https://github.com/apache/iceberg/pull/8755#discussion_r1433435467
########## core/src/main/java/org/apache/iceberg/deletes/PositionDeleteIndex.java: ########## @@ -44,4 +44,14 @@ public interface PositionDeleteIndex { /** Returns true if this collection contains no element. */ boolean isEmpty(); + + /** Returns true if this collection contains elements. */ + default boolean isNotEmpty() { Review Comment: is this really needed? (versus !empty?) ########## core/src/main/java/org/apache/iceberg/deletes/PositionDeleteIndex.java: ########## @@ -44,4 +44,14 @@ public interface PositionDeleteIndex { /** Returns true if this collection contains no element. */ boolean isEmpty(); + + /** Returns true if this collection contains elements. */ + default boolean isNotEmpty() { Review Comment: is this really needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org