rdblue commented on code in PR #9359:
URL: https://github.com/apache/iceberg/pull/9359#discussion_r1440814517
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/BaseBatchReader.java:
##########
@@ -53,6 +58,7 @@ abstract class BaseBatchReader<T extends ScanTask> extends
BaseReader<ColumnarBa
protected CloseableIterable<ColumnarBatch> newBatchIterable(
InputFile inputFile,
+ ByteBuffer keyMetadata,
Review Comment:
Looks like these changes can't be made to the corresponding
`BaseBatchReader` in `iceberg-arrow` because it is public. I think that means
that Arrow cannot support reading from encrypted tables in this PR even if it
calls the `EncryptionManager` correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
