liurenjie1024 commented on code in PR #129:
URL: https://github.com/apache/iceberg-rust/pull/129#discussion_r1441248686
##########
crates/iceberg/src/spec/snapshot.rs:
##########
@@ -124,6 +150,70 @@ impl Snapshot {
Utc.timestamp_millis_opt(self.timestamp_ms).unwrap()
}
+ /// Get the schema id of this snapshot.
+ #[inline]
+ pub fn schema_id(&self) -> Option<SchemaId> {
+ self.schema_id
+ }
+
+ /// Get the schema of this snapshot.
+ pub fn schema(&self, table_metadata: &TableMetadata) -> Result<SchemaRef> {
+ Ok(match self.schema_id() {
+ Some(schema_id) => table_metadata
+ .schema_by_id(schema_id)
+ .ok_or_else(|| {
+ Error::new(
+ ErrorKind::DataInvalid,
+ format!("Schema with id {} not found", schema_id),
+ )
+ })?
+ .clone(),
+ None => table_metadata.current_schema().clone(),
+ })
+ }
Review Comment:
This method is used to fetch the schema of a snapshot, so I think this is
compatible with java/python behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
