amogh-jahagirdar commented on code in PR #9298:
URL: https://github.com/apache/iceberg/pull/9298#discussion_r1442241575
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/BaseFileRewriteCoordinator.java:
##########
@@ -72,18 +70,12 @@ public void clearRewrite(Table table, String fileSetId) {
public Set<String> fetchSetIds(Table table) {
return resultMap.keySet().stream()
- .filter(e -> e.first().equals(tableUUID(table)))
+ .filter(e -> e.first().equals(Spark3Util.tableUUID(table)))
Review Comment:
Nit: I think it would be a bit cleaner just to import Spark3Util.tableUUID
and then just use tableUUID here (the diff on line 73 and other places would
essentially go away in favor of just a new import statement). But that's nbd,
if we do the method rename like I suggested we lose this benefit anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
