rdblue commented on code in PR #9421:
URL: https://github.com/apache/iceberg/pull/9421#discussion_r1443226670
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##########
@@ -635,6 +633,51 @@ private Catalog tableCatalog() {
return Spark3Util.loadIcebergCatalog(spark, catalogName);
}
+ @Test
+ public void dropView() {
+ String viewName = "viewToBeDropped";
+ String sql = String.format("SELECT id FROM %s", tableName);
+
+ ViewCatalog viewCatalog = viewCatalog();
+
+ TableIdentifier identifier = TableIdentifier.of(NAMESPACE, viewName);
+ viewCatalog
+ .buildView(identifier)
+ .withQuery("spark", sql)
+ .withDefaultNamespace(NAMESPACE)
+ .withDefaultCatalog(catalogName)
+ .withSchema(schema(sql))
+ .create();
+
+ assertThat(viewCatalog.viewExists(identifier)).isTrue();
+
+ sql("DROP VIEW %s", viewName);
+ assertThat(viewCatalog.viewExists(identifier)).isFalse();
+ }
+
+ @Test
+ public void dropNonExistingView() {
+ assertThatThrownBy(() -> sql("DROP VIEW non_existing"))
+ .isInstanceOf(AnalysisException.class)
+ .hasMessageContaining("The view %s.%s cannot be found", NAMESPACE,
"non_existing");
+
+ assertThatNoException().isThrownBy(() -> sql("DROP VIEW IF EXISTS
non_existing"));
Review Comment:
Nit: I think that `IF EXISTS` is a separate option and probably deserves a
separate test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
