chinmay-bhat commented on code in PR #9401:
URL: https://github.com/apache/iceberg/pull/9401#discussion_r1443955073
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestTimestampWithoutZone.java:
##########
@@ -145,33 +137,31 @@ public void testAppendTimestampWithZone() {
toTimestamp("2021-02-01T00:00:00.0")))));
}
- @Test
+ @TestTemplate
public void testCreateAsSelectWithTimestampWithoutZone() {
sql("INSERT INTO %s VALUES %s", tableName, rowToSqlValues(values));
sql("CREATE TABLE %s USING iceberg AS SELECT * FROM %s", newTableName,
tableName);
- Assert.assertEquals(
- "Should have " + values.size() + " row",
- (long) values.size(),
- scalarSql("SELECT count(*) FROM %s", newTableName));
+ assertThat(scalarSql("SELECT count(*) FROM %s", newTableName))
+ .as("Should have " + values.size() + " row")
+ .isEqualTo((long) values.size());
Review Comment:
no, not needed. Will update this too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
