ZENOTME commented on issue #159:
URL: https://github.com/apache/iceberg-rust/issues/159#issuecomment-1888563964
>When user construction UnboundExpression, it's not always from sql. For
example when we integrate it with other sql engines, it may push filter to
iceberg api to construct UnboundExpression.
>The parse string method implemented in pyiceberg is not a typical approach
in rust. Rust has elegant support for macros, which is efficient and type safe.
This case looks reasonable to me.
> So my proposal is that we still make BoundLiteral public, but we should be
careful not exposing its internals in public api. For the first version, we'll
only expose builder methods so that users can create it easily, and no
internals will be exposed.
Does this proposal look like following?
```
let literal = BoundLiteral::builder.with_literal(...).build();
TableScan scan = scan.filter(Expressions.equal("id", literal));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
