ajantha-bhat commented on code in PR #9273:
URL: https://github.com/apache/iceberg/pull/9273#discussion_r1452857004
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##########
@@ -848,6 +849,16 @@ public void
testRewriteWithUntranslatedOrUnconvertedFilter() {
.hasMessageContaining("Cannot convert Spark filter");
}
+ @Test
+ public void testAddApplicationIdInSummary() {
+ createPartitionTable();
+ // create 5 files for each partition (c2 = 'foo' and c2 = 'bar')
+ insertData(10);
+ sql("CALL %s.system.rewrite_data_files(table => '%s')", catalogName,
tableIdent);
+
+ assert (snapshotSummary().containsKey(CatalogProperties.APP_ID));
Review Comment:
nit: we can probably add this validation in
`testRewriteDataFilesOnPartitionTable` itself. We may not want to increase the
CI time by creating table, loading data and rewriting just to validate this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
