bugorz commented on code in PR #9335:
URL: https://github.com/apache/iceberg/pull/9335#discussion_r1452995549
##########
core/src/main/java/org/apache/iceberg/AllEntriesTable.java:
##########
@@ -64,9 +84,18 @@ protected TableScan newRefinedScan(Table table, Schema
schema, TableScanContext
@Override
protected CloseableIterable<FileScanTask> doPlanFiles() {
- CloseableIterable<ManifestFile> manifests =
- reachableManifests(snapshot -> snapshot.allManifests(table().io()));
- return BaseEntriesTable.planFiles(table(), manifests, tableSchema(),
schema(), context());
+ return new ParallelIterable<>(
Review Comment:
@szehon-ho Thanks for your feedback!
> Looks like we don't close the ParallelIterable like in the original
reachableManifests method.
Good catch! Let me fix it.
> Also looks like we are going to call planFiles many more times than the
original.
Let me think about it, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
