ajantha-bhat commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1457044287
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -157,8 +159,10 @@ private void initializeCatalogTables() throws
InterruptedException, SQLException
return true;
}
- LOG.debug("Creating table {} to store iceberg catalog",
JdbcUtil.CATALOG_TABLE_NAME);
- return
conn.prepareStatement(JdbcUtil.CREATE_CATALOG_TABLE).execute();
+ LOG.debug(
+ "Creating table {} to store iceberg catalog tables",
JdbcUtil.CATALOG_TABLE_NAME);
+ return
conn.prepareStatement(JdbcUtil.createCatalogTableOrViewSqlStatement(true))
Review Comment:
> not sure these methods are actually used by end user though
True. Since previous SQL like `JdbcUtil.CREATE_CATALOG_TABLE` was package
private. Maybe these methods can also be package private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
