nastra commented on code in PR #9423:
URL: https://github.com/apache/iceberg/pull/9423#discussion_r1467282732
##########
spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ExtendedDataSourceV2Strategy.scala:
##########
@@ -107,6 +108,21 @@ case class ExtendedDataSourceV2Strategy(spark:
SparkSession) extends Strategy wi
case DropIcebergView(ResolvedIdentifier(viewCatalog: ViewCatalog, ident),
ifExists) =>
DropV2ViewExec(viewCatalog, ident, ifExists) :: Nil
+ case CreateIcebergView(ResolvedIdentifier(viewCatalog: ViewCatalog,
ident), queryText, query,
+ columnAliases, columnComments, queryColumnNames, comment, properties,
allowExisting, replace, _) =>
+ CreateV2ViewExec(
+ catalog = viewCatalog,
+ ident = ident,
+ queryText = queryText,
+ columnAliases = columnAliases,
+ columnComments = columnComments,
+ queryColumnNames = queryColumnNames,
Review Comment:
technically we don't need to track it in this PR but we'll eventually need
it when we show the properties of views and such. I'd probably keep it here but
let me know if you'd like me to remove it here and introduce it in an upcoming
PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
