rdblue commented on a change in pull request #922:
URL: https://github.com/apache/iceberg/pull/922#discussion_r441204896



##########
File path: core/src/test/java/org/apache/iceberg/TestManifestReader.java
##########
@@ -103,4 +107,28 @@ public void 
testManifestReaderWithUpdatedPartitionMetadataForV1Table() throws IO
     }
   }
 
+  @Test
+  public void testManifestReaderWithPartitionMetadataEvolution() throws 
IOException {
+    table.updateSpec().clear()

Review comment:
       I don't think these test cases should use `clear`. Most evolution should 
happen by adding and removing fields, so our tests should do the same.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to