nastra commented on code in PR #9584:
URL: https://github.com/apache/iceberg/pull/9584#discussion_r1471399965
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestExpireSnapshotsProcedure.java:
##########
@@ -541,6 +541,29 @@ public void
testExpireSnapshotsWithPartitionStatisticFiles() {
.exists();
}
+ @Test
+ public void testExpireSnapshotsNotDeletingFiles() {
+ sql("CREATE TABLE %s (id bigint NOT NULL, data string) USING iceberg",
tableName);
+
+ sql("INSERT INTO TABLE %s VALUES (1, 'a')", tableName);
+ sql("INSERT INTO TABLE %s VALUES (2, 'b')", tableName);
+
+ Table table = validationCatalog.loadTable(tableIdent);
+
+ Assert.assertEquals("Should be 2 snapshots", 2,
Iterables.size(table.snapshots()));
Review Comment:
```suggestion
assertThat(table.snapshots()).hasSize(2);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
