Fokko commented on code in PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#discussion_r1474126225
##########
tests/catalog/test_base.py:
##########
@@ -355,8 +162,6 @@ def test_create_table_pyarrow_schema(catalog:
InMemoryCatalog, pyarrow_schema_si
table = catalog.create_table(
identifier=TEST_TABLE_IDENTIFIER,
schema=pyarrow_schema_simple_without_ids,
- location=TEST_TABLE_LOCATION,
- partition_spec=TEST_TABLE_PARTITION_SPEC,
Review Comment:
I agree with you @syun64 that for creating tables having to look up the IDs
is not ideal. Probably that API has to be extended at some point.
But for the metadata (and also how Iceberg internally tracks columns, since
names can change; IDs not), we need to track it by ID. I'm in doubt if
assigning `-1` was the best idea because that will give you a table that you
cannot work with. Thanks for creating the issue, and let's continue there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
