aokolnychyi commented on code in PR #9437:
URL: https://github.com/apache/iceberg/pull/9437#discussion_r1475181311
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkAction.java:
##########
@@ -150,6 +154,21 @@ protected Dataset<FileInfo> contentFileDS(Table table,
Set<Long> snapshotIds) {
Broadcast<Table> tableBroadcast =
sparkContext.broadcast(serializableTable);
int numShufflePartitions =
spark.sessionState().conf().numShufflePartitions();
+ return manifestBeanDS(table, snapshotIds, numShufflePartitions)
+ .flatMap(new ReadManifest(tableBroadcast), FileInfo.ENCODER);
+ }
+
+ protected Dataset<PartitionEntryBean> partitionEntryDS(Table table) {
+ Table serializableTable = SerializableTableWithSize.copyOf(table);
+ Broadcast<Table> tableBroadcast =
sparkContext.broadcast(serializableTable);
+ int numShufflePartitions =
spark.sessionState().conf().numShufflePartitions();
+
+ return manifestBeanDS(table, null, numShufflePartitions)
Review Comment:
I think our decisions in this PR would affect what we do in #9170, so let's
wait for some clarity here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
