HonahX commented on code in PR #352:
URL: https://github.com/apache/iceberg-python/pull/352#discussion_r1475415226
##########
pyiceberg/schema.py:
##########
@@ -221,6 +227,11 @@ def find_type(self, name_or_id: Union[str, int],
case_sensitive: bool = True) ->
def highest_field_id(self) -> int:
return max(self._lazy_id_to_name.keys(), default=0)
+ def name_mapping(self) -> NameMapping:
Review Comment:
Could this be a `@cached_property` since schema is immutable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
