ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475772911
##########
crates/iceberg/src/io.rs:
##########
@@ -268,6 +268,16 @@ impl OutputFile {
.await?)
}
+ /// Delete file.
+ pub async fn delete(&self) -> Result<()> {
Review Comment:
I find that we don't need to delete empty files in this writer. We can do
this thing in the upper writer and make this writer be simple. This writer only
responded to get an output file and write it.
And I find that for FileWriterBuilder should accept the output file when
built. We hope to clone the builder and rebuild a writer using a new output
file, which means that the builder state should be bound with any output file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
