rdblue commented on code in PR #9629:
URL: https://github.com/apache/iceberg/pull/9629#discussion_r1476874138
##########
core/src/main/java/org/apache/iceberg/PartitionData.java:
##########
@@ -171,6 +169,10 @@ public PartitionData copy() {
return new PartitionData(this);
}
+ public PartitionData copyFor(StructLike partition) {
Review Comment:
I find this API to be a bit awkward. I'd rather have a more straightforward
two-step process to copy the key without copying values (like `emptyCopy()`)
and then fill that with values. Otherwise "copy" doesn't really describe this
action, which copies behavior but not data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
