rdblue commented on code in PR #9323:
URL: https://github.com/apache/iceberg/pull/9323#discussion_r1477125444
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -221,34 +223,52 @@ protected boolean addsDeleteFiles() {
/** Add a data file to the new snapshot. */
protected void add(DataFile file) {
Preconditions.checkNotNull(file, "Invalid data file: null");
- setDataSpec(file);
- addedFilesSummary.addedFile(dataSpec(), file);
+ addDataFile(new FileHolder<>(file));
+ }
+
+ /** Add a data file to the new snapshot. */
+ protected void add(DataFile file, long dataSequenceNumber) {
+ Preconditions.checkNotNull(file, "Invalid data file: null");
+ addDataFile(new FileHolder<>(file, dataSequenceNumber));
Review Comment:
The caller can't reliably supply a sequence number. Let's talk about this on
Tuesday. I think there's a way that you can update this class to do what you
want, but it's going to be a bit more work than what you have here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
