nastra commented on code in PR #9619:
URL: https://github.com/apache/iceberg/pull/9619#discussion_r1477771865
##########
core/src/test/java/org/apache/iceberg/util/TestLocationUtil.java:
##########
@@ -46,6 +46,21 @@ public void testStripTrailingSlash() {
assertThat(LocationUtil.stripTrailingSlash(pathWithOnlySlash))
.as("Should have no trailing slashes")
.isEmpty();
+
+ String rootPath = "blobstore://";
Review Comment:
can you please separate these all into their own separate test methods? That
was we test only a single thing per test method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
