jbonofre commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1480332429
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -245,13 +290,30 @@ public List<TableIdentifier> listTables(Namespace
namespace) {
row ->
JdbcUtil.stringToTableIdentifier(
row.getString(JdbcUtil.TABLE_NAMESPACE),
row.getString(JdbcUtil.TABLE_NAME)),
- JdbcUtil.LIST_TABLES_SQL,
+ JdbcUtil.LIST_TABLE_SQL,
catalogName,
- JdbcUtil.namespaceToString(namespace));
+ JdbcUtil.namespaceToString(namespace),
+ JdbcUtil.TABLE_RECORD_TYPE);
}
@Override
public void renameTable(TableIdentifier from, TableIdentifier to) {
+ if (!tableExists(from)) {
Review Comment:
I have to test the table first to make
`TestJdbcCatalog#testRenameTableMissingSourceTable()` happy, else I get:
```
Expecting actual throwable to be an instance of:
org.apache.iceberg.exceptions.NoSuchTableException
but was:
org.apache.iceberg.exceptions.NoSuchNamespaceException: Namespace does
not exist: newdb
```
The reason is because, the test expects the `NoSuchTableException` because
the `NoSuchNamespaceException` one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
