raptond commented on a change in pull request #1126:
URL: https://github.com/apache/iceberg/pull/1126#discussion_r443182111



##########
File path: 
spark/src/test/java/org/apache/iceberg/spark/source/TestSparkTableUtil.java
##########
@@ -131,17 +133,17 @@ public void after() throws IOException {
   }
 
   @Test
-  public void testPartitionScan() {
-    Seq<SparkPartition> partitions = SparkTableUtil.getPartitions(spark, 
qualifiedTableName);
+  public void testPartitionScan() throws NoSuchDatabaseException, 
NoSuchTableException, ParseException {

Review comment:
       I have addressed this here: 
https://github.com/apache/iceberg/pull/1126/commits/556754c65bf1d9cd97bb8e51263f8c7db8a87b95#diff-fa1251337fb4092082819225c9e40a80R39
   
   @aokolnychyi - Though I have created a class ExceptionUtil.java which does 
the mapping of specific *checked exceptions* to *unchecked equivalents*, I have 
to make it in the spark module because the exceptions depend on Spark 
libraries. Let me know if you want to move it to elsewhere. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to