aokolnychyi commented on code in PR #9605:
URL: https://github.com/apache/iceberg/pull/9605#discussion_r1484656650
##########
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##########
@@ -118,4 +118,9 @@ public interface ExpireSnapshots extends
PendingUpdate<List<Snapshot>> {
* @return this for method chaining
*/
ExpireSnapshots cleanExpiredFiles(boolean clean);
+
+ /** Returns number of expired snapshots */
+ default long expiredSnapshotsCount() {
+ return 0L;
Review Comment:
Actually, I thought it was an action class. I am still worried about
exposing this stateful method in our public API. I wonder if offering some sort
of commit hooks that would have access to the state before and after would be a
better idea.
@rdblue @nastra @manuzhang @amogh-jahagirdar, any thoughts? I guess we can
compute this one in particular externally by comparing the number of snapshots
before and after the commit call, but it seems like a common problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
